search

NotNite / DistantSeas

Dalamud plugin that aims to improve Ocean Fishing
GNU Affero General Public License v3.0
8 stars 7 forks source link

Added Spectral Timer #6

Closed spide-r closed 9 months ago

spide-r commented 9 months ago

Spectral Timer + New Setting to only show the overlay header.

NotNite commented 9 months ago

/remindme 1h30m image

spide-r commented 9 months ago

Resolved issue w/ spec timer in first zone + made sure that the spectral timer never exceeded the actual time remaining in the instance (factoring in the hard-stop at 30s).

spide-r commented 9 months ago

no spec -> late spec -> spec caused timer to go in the negatives

reviewing

Nukoooo commented 9 months ago

While you are at it, wouldn't it better to hook the update thingy function for InstanceContentOceanFishing? Possibly refactoring other code with this function, since the game handles most of the ocean fishing related in this function, tho updating caught fish is done in a network packet.

https://github.com/Nukoooo/Dalamud.FishersIntuition/blob/5013c9bae0b8f747f4546eb61a6a7ebbe84b2612/FishersIntuition/Timers/WeatherTimer.cs#L40-L44 (my code works in most cases, but when a spectral happens when the current zone has only about one and a half minutes left, the timer in the next zone will have 10+ seconds more than the actual timer)

Edit: SetSpawnPlaceName type is wrong btw, I have no idea what it is. I tried to figure out if it is accessed by anything but it seems like nothing actually accesses the fields that type 10 updates

NotNite commented 9 months ago

Should this be marked as a draft or is it ready to merge?

spide-r commented 9 months ago

I want to say ready to merge but I want to test it one final time at the 10pm GMT boat.

spide-r commented 9 months ago

@NotNite ready to merge