NotRanged / NotRanged.github.io

Web frontend for FFXIV Crafting Optimizer service.
zlib License
73 stars 43 forks source link

Intensive Synthesis is considered "Guaranteed" #42

Closed octylFractal closed 1 year ago

octylFractal commented 2 years ago

Required Information

Class: Armorer Level: 78 Craftsmanship: 1633 Control: 1507 CP: 429 Recipe Name: Rarefied Titanbronze Tower Shield Recipe Level: 78 Solver Seed: 20630

Expected Behaviour

Intensive Synthesis, which is conditional on Material Condition, should not be selected when using "Guaranteed (By Level)" to pick actions. Arguably Tricks of the Trade falls under this too.

Actual Behaviour

These skills are auto-selected as "Guaranteed" actions.

Steps To Reproduce

Pick a level 78 Armorer, click "Guaranteed (By Level)", notice that Intensive Synthesis was selected.

MartinCa commented 2 years ago

I believe this is correct since the action is guaranteed when the required condition is met. The solver should then make sure the action is only selected when the required condition is met.

octylFractal commented 2 years ago

AFAIK condition is random and therefore there is no point where it is 100% guaranteed to be Good or Excellent.

MartinCa commented 2 years ago

You are right, my mistake. It seems the solver will skip them regardless of whether they are selected or not. However I agree it would make sense that they should not be added.

I have created a PR to fix this.