NotSqrt / mattermost-integration-gitlab

Send events from Gitlab to Mattermost through webhooks
https://www.mattermost.org/webhooks/
Apache License 2.0
99 stars 45 forks source link

No access control? #15

Closed mariusk closed 8 years ago

mariusk commented 8 years ago

I've gotten everything working, BUT it means I'm now running a daemon on port 5000 (or any other port number) that anybody can connect to (and create messages in my Mattermost channel). I could use firewall rules to limit connections, but then I would need to know all IPs Gitlab could use. Another alternative would be to add some magic cookie or similar to at least minimize unauthorized connections to the port. Is any of this supported already, and if so, how would I do it?

NotSqrt commented 8 years ago

Hello,

There's no access control within this app. I only use it on localhost, so no exposed service or open port..

To handle authentication, I guess I would set up a reverse proxy (nginx/apache) with basic auth in front of this daemon, and potentially HTTPS. I assume that using a hook url of the form http://username:password@ip:port in gitlab will work, so that basic auth can be used easily ...

That's about it without modifications of the python code.

mariusk commented 8 years ago

Ah, yes, if you self host there are no issues. If you use hosted Gitlab however.. Thanks for responding anyway.