NotSqrt / mattermost-integration-gitlab

Send events from Gitlab to Mattermost through webhooks
https://www.mattermost.org/webhooks/
Apache License 2.0
99 stars 45 forks source link

Set webhook_url as url parameter instead of in config. #36

Open fsobanski opened 7 years ago

fsobanski commented 7 years ago

This pull request is based on PR #4.

Instead of setting MATTERMOST_WEBHOOK_URL when starting the server, the url must now be passed as an url parameter in the form

http:///new_event?mattermost_webhook_url=

I updated the tests and the readme, just as @NotSqrt requested in PR #4.

This pull request should fix issue #2.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.8%) to 89.157% when pulling ff49fe9232a065bbcb0baab95650ef3f54a5de4f on iteratec:master into 4a61a4885afd674528f27e96b7de80e5e67befdf on NotSqrt:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.8%) to 89.157% when pulling ff49fe9232a065bbcb0baab95650ef3f54a5de4f on iteratec:master into 4a61a4885afd674528f27e96b7de80e5e67befdf on NotSqrt:master.

jarvisaoieong commented 7 years ago

👍