search

NotTobi / soundcloud-dl

Extension for downloading SoundCloud tracks
https://addons.mozilla.org/firefox/addon/soundcloud-dl
MIT License
93 stars 7 forks source link

WAV files incorrectly download as mp3 / add support for setting metadata on WAV files #27

Closed gabhab closed 3 years ago

gabhab commented 3 years ago

When a track is available for download already, but isn't in mp3 format (e.g. in the example below, it's a wav file), I seem to get a downloaded file which has .mp3 as an extension, but is the same size as the .wav file would have been. Is this intentional? Ideally I would be able to have the wav file but with soundcloud-dl setting the metadata.

https://soundcloud.com/honchopgh/honcho-podcast-series-97-baronhawk-poiter

[2021-07-03T08:54:39.842Z] [SOUNDCLOUD-DL:SoundCloudApi] Getting original download URL for track with Id 1052926822 background.js:7853:25 Object { streams: (4) […] } background.js:6242:13 [2021-07-03T08:54:39.959Z] [SOUNDCLOUD-DL:Background] Including high quality streams! background.js:7853:25 [2021-07-03T08:54:39.959Z] [SOUNDCLOUD-DL:Background] Initiating download of 1052926822 with payload Object { payload: {…} } background.js:7853:25 [2021-07-03T08:54:39.963Z] [SOUNDCLOUD-DL:Background] Starting download of 'Honcho - Honcho Podcast Series 97 Baronhawk Poiter' (TrackId: 1052926822)... background.js:7853:25 [2021-07-03T08:55:02.712Z] [SOUNDCLOUD-DL:Background] Inferred file extension from 'content-type' header (TrackId: 1052926822) Object { contentType: "audio/wav", extension: "mp3" } background.js:7853:25 [2021-07-03T08:55:03.533Z] [SOUNDCLOUD-DL:Background] Downloading track as 'Honcho - Honcho Podcast Series 97 Baronhawk Poiter.mp3' (TrackId: 1052926822)... background.js:7853:25 [2021-07-03T08:55:06.599Z] [SOUNDCLOUD-DL:Background] Successfully downloaded 'Honcho - Honcho Podcast Series 97 Baronhawk Poiter' (TrackId: 1052926822)! background.js:7853:25

NotTobi commented 3 years ago

First of all it seems to be a bug that it is not inferring audio/wav as .wav but .mp3. Will fix this asap! About setting the metadata of wav files. I will look into it.

NotTobi commented 3 years ago

Just published v1.12.1 which should correctly infer the file extension.

NotTobi commented 3 years ago

I also added support for setting .wav metadata in v1.13.0.

I'm closing this ticket, feel free to re-open if there are still issues! :)

Also please leave a positive review for the extension, if you haven't already - it helps a lot :heart:

gabhab commented 3 years ago

Amazing, thank you! Review left.

gabhab commented 3 years ago

I'm having what I think it the same issue with .aif files, e.g. with this one:

https://soundcloud.com/beyondbelow/b8-ali-wade

NotTobi commented 3 years ago

Hi again :) I don't think I will add support for .aif. It's a relatively uncommon format and supporting it is not worth the development time. I will probably just add some code to bail out, if a format other than mp3, m4a or wav is detected and fallback to mp3/m4a. Just really busy at the moment, so maybe it will take a while, before I can get to it.

gabhab commented 3 years ago

Thanks! I completely understand (and I think I only run into it with that particular podcast series), it's not a big issue at all.