NotTooManyItems / StepUp

StepUp
2 stars 9 forks source link

[Bug] Stepheight is being set instead of being added/removed from #18

Open Speiger opened 2 years ago

Speiger commented 2 years ago

Honestly stepheight should be a "IAttribute" But yeah the way stepup is implemented it breaks basically anything that has stepassist implemented.

So what you should change is use a += & -= instead of a = for setting stepheight and use a boolean to keep track of if you added it or not. Because if a mod comes and uses += & -= and yours is overriding it that can cause that stepassist breaks and you cant even go up stairs anymore.

ghost commented 1 year ago

@Speiger do you know how to fix this bug? https://youtu.be/Zz1mtYPrqkc

Speiger commented 1 year ago

@SegoItCh simpley do a += and -= when added and removed instead of: = Simply add a modifier to it instead of multiplying XD

ghost commented 5 months ago

@NotTooManyItems can you at least fix this issue since "All rights reserved"?