Closed bokyeong1015 closed 6 months ago
@bokyeong1015 Most changes in this PR are LGTM. I have two suggestions:
As one of the unit tests, could you provide some example setting/result that reproduce metrics in paper or technical reports?
Why don't we make default value of add_bos_to_every=True
? My understanding is that keeping the add_bos_to_every=False
setting is to reproduce past paper results, however, this setting cause inconsistent evaluation between samples in batches. (i.e., BOS is appended for only first sample).
Description
Changes
src/LLMPruner/datasets/example_samples.py
-> moved intosrc/dataset.py
src/LLMPruner/datasets/ppl_dataset.py
-> moved intosrc/dataset.py
src/LLMPruner/evaluator/ppl.py
-> merged intosrc/eval_ppl.py
Note
results/$MODEL_NAME/ppl
)ppl.csv
: BOS token is added to only the first segment; previous implementation (add_bos_to_every=False
)ppl_bos.csv
: BOS token is added to all segments; new implementation (add_bos_to_every=True
)