Notalib / LYT

m.e17.dk

GNU Lesser General Public License v3.0

10 stars 12 forks source link

Remove user agent sniffing in player.coffee #314

Closed mzedeler closed 11 years ago

mzedeler commented 12 years ago

In player.coffee, we have @isIOS() living alongside manual tests for the same thing (see loadstart). The general principle is that we shouldn't ever look at user agents identifiers because they are unreliable wrt. to detecting which features that work.

This task consists of removing all references to @isIOS() (or other user agent sniffing tests, such as $.jPlayer.platform.*) and the code that executes when @isIOS() returns true. Places where user agent sniffing is required for the player to work, should be left as is.

everhoej commented 12 years ago

This task can make the player quite unstable, therefore we decided to remove the issue from Milestone Sprint 1. The task would be great for a clean up...

everhoej commented 11 years ago

points:5

mzedeler commented 11 years ago

I've removed user agent sniffing from some surprising locations, so we need to test the following as part of testing this issue:

Sharing a bookmark (especially on IOS and IE).
- The text in the box containing the link should automatically be selected when the user clicks on it.
- Sharing via mail should still work (check that everything is encoded properly).
The stack renderer should be able to scroll horizontally if there isn't room for the content in it.

The fix didn't remove any code from the player that had any effect.

mzedeler commented 11 years ago

There is a lot of testing and possible bug fixing to do.

points:4.

LDHgithub commented 11 years ago

points:3

LDHgithub commented 11 years ago

This is fixed...

points:0

everhoej commented 11 years ago

Ready to be cloced @LDHgithub ?

LDHgithub commented 11 years ago

yup...