search

Notalib / LYT

m.e17.dk
GNU Lesser General Public License v3.0
10 stars 12 forks source link

Always lookup lowercase uri in @resources #683

Closed saebekassebil closed 9 years ago

saebekassebil commented 9 years ago

Fixes an issue that prevented playing and/or viewing the contents of a range of journals (Inspiration, etc).

mzedeler commented 9 years ago

Isn't this going to break servers that do the right thing (tm) with regard to casing? This looks like a materials issue.

Sent from my Sony Xperia™ smartphone

---- Jakob Miland wrote ----

Fixes an issue that prevented playing and/or viewing the contents of a range of journals (Inspiration, etc).

You can view, comment on, or merge this pull request online at:

  https://github.com/Notalib/LYT/pull/683

Commit Summary

Always lookup lowercase uri in @resources

File Changes

M src/view/render/content.coffee (2)

Patch Links:

https://github.com/Notalib/LYT/pull/683.patchhttps://github.com/Notalib/LYT/pull/683.diff

— Reply to this email directly or view it on GitHub.

saebekassebil commented 9 years ago

Well, I guess it is a material issue, but I remember way back, that we decided to lowercase all resources, because there was a huge amount of books that didn't get it right.

Problem is we only did it halfway apparently. https://github.com/Notalib/LYT/blob/master/src/models/book/book.coffee#L110

I was going to merge this and deploy, but I'll wait for an OK then :)

saebekassebil commented 9 years ago

Introduced in PR #630

saebekassebil commented 9 years ago

And no. It's not going to break any servers. It'll only break books with files that have similar filenames with different casings. (a.html and A.htMl). But I don't think this is anything to worry about and I kinda recall that it's prohibited by the DAISY standard for legacy reasons.