search

Notalib / nativescript-webview-ext

Nativescript plugin with extended WebView functionality
Apache License 2.0
76 stars 37 forks source link

Scrolling not working on iOS 12.1.1 #16

Closed singhsaban closed 5 years ago

singhsaban commented 5 years ago

Hi, The scrolling issue has re-appeared for iOS 12.1.1 #8 .

I noticed that scrolling has been turned off in nativescript-webview-ext/webview-ext.uiwebview.js.

uiWebView.scrollView.scrollEnabled = false;

And setting this to true does fix the issue. Let me know if this is a valid fix for the issue. I could send in a PR.

Thanks.

m-abs commented 5 years ago

Hmm, that's odd.

UIWebview shouldn't be used on iOS 12.x.

m-abs commented 5 years ago

Could you provide an example project for this issue?

singhsaban commented 5 years ago

Hi @m-abs , I've created a demo nativescript-vue project https://github.com/singhsaban/webview-ext-demo. To replicate the issue on iOS 12.1.1 make the following true in the webview-ext package itself.

uiWebView.scrollView.scrollEnabled = false;

m-abs commented 5 years ago

Hi thanks,

I've removed that line and fixed the test for UIWebView or WKWebView. Only older versions of iOS should use UIWebView but 12.1.1 resulted in a NaN so the check failed.

Try updating to latest version.

singhsaban commented 5 years ago

Thanks @m-abs for the fix.