NoteGio / openrelay

OpenRelay is an open source relay for the 0x protocol. OpenRelay provides an open, scalable orderbook. Users can post offers for any ERC20 or ERC721 token, or search for trades with other users
Other
159 stars 56 forks source link

It turns out that Bloom.Test() doesn't actually work with Ethereum #129

Closed AusIV closed 5 years ago

AusIV commented 5 years ago

bloom filters if any of the topics have leading 0 bytes. That issue is documented here: https://github.com/ethereum/go-ethereum/issues/18092

This switches to using the BloomLookup() method, which works correctly.

The only place this was actually a problem was the approvals monitors. All of the others only relied on topics that were 32 bytes instead of 20 or less.