Closed mathieuboudreau closed 1 year ago
[x] ~Figure 1~
[x] Figure 2
[x] Figure 3
[x] Figure 4
[x] Figure 5
[x] Figure 6
[ ] Introduction
[ ] Abstract
[ ] Add external link to the sidebar to the paper
[ ] Remove all old static matplotlib figures & code
[ ] Split figures into different pages to speed up loading times
[ ] Hide all code above figures
[ ] Split code like this (with hidden cells)
To do:
Later on to-do (after figures have been formatted...
Guys, just wanted to let you know I've done everything we discussed regarding the appearance of the figures. @mathieuboudreau please check if everything is okay with the last two subplots (the two histograms) of the last figure.
@FilipVel thank you, this looks really nice! For convenience, can you add the link to the book in your comments for convenience? I have some comments:
[ ] In Figure 6 traces
do not have names, instead we see trace indexes when hovered. Can you give those traces (blue, organge, yellow histograms) labels if colors are coded in the figure caption?
[ ] The supplemental figure](https://notebook-factory.github.io/BayesianRepetoireOverlap/03Code/manusssscriptCalculations.html#Supplemental-Figure:-What-if-$n_a-\neq-n_b$-?) has Select Here
as the default. Can you change it to this:
Thanks @agahkarakuzu , I've updated the book with the changes made. I didn't quite understand the part with the link. Were you thinking about adding the link to the book in a comment here, on this issue?
Were you thinking about adding the link to the book in a comment here, on this issue?
Yes, in just one of the comments to the book, nothing special :) I will take a look at your changes, see you in the meeting soon!
@mathieuboudreau , @agahkarakuzu Guys, Should I create separate notebooks for the unpublished figures, created with matplotlib, or should I leave them out of the book completely for now?
If they aren't the figures in the paper, I would leave them out of the Jupyter Book for now
So I think I've done everything that we discussed today. You can check out the results here Please update me if I need to make some other changes.
Edit: I actually added the supplemental figure, as it was somewhat present in the paper, as supporting information.
@FilipVel It looks great! The only thing that I'd recommend (and this goes for @zelenkastiot as well) is to have text labels next to the +- code collapse buttons to explain what each block is (e.g. "Code imports", "Functions" "Script" "Plot"), and to also include the figure captions that are inside the paper for each of them, e.g.:
@FilipVel We (@zelenkastiot and @TommyBoshkovski to be exact) made the additional changes needed before sending it to the authors today - so no need to work on this on the weekend on your end!
Okay, great, thanks guys!
Just trying something
Meeting to do list:
Paper: https://journals.plos.org/ploscompbiol/article?id=10.1371/journal.pcbi.1006898 Code: https://github.com/dblarremore/BayesianRepertoireOverlap/ Note: Python 3, Jupyter notebooks, but reproduces all figures from paper.