Notebook-Factory / assign

Repo to assign papers to factory workers.
0 stars 0 forks source link

"Bayes-optimal estimation of overlap between populations of fixed size" #2

Closed mathieuboudreau closed 1 year ago

mathieuboudreau commented 4 years ago

Paper: https://journals.plos.org/ploscompbiol/article?id=10.1371/journal.pcbi.1006898 Code: https://github.com/dblarremore/BayesianRepertoireOverlap/ Note: Python 3, Jupyter notebooks, but reproduces all figures from paper.

mathieuboudreau commented 4 years ago

To-Do (Create Plotly Figures)

mathieuboudreau commented 4 years ago

To do (Format figures like paper)

mathieuboudreau commented 4 years ago

To Do (Format Jupyter Book)

mathieuboudreau commented 4 years ago

Notes from June 30th meeting

To do:

Later on to-do (after figures have been formatted...

FilipVel commented 4 years ago

Guys, just wanted to let you know I've done everything we discussed regarding the appearance of the figures. @mathieuboudreau please check if everything is okay with the last two subplots (the two histograms) of the last figure.

agahkarakuzu commented 4 years ago

@FilipVel thank you, this looks really nice! For convenience, can you add the link to the book in your comments for convenience? I have some comments:

image

FilipVel commented 4 years ago

Thanks @agahkarakuzu , I've updated the book with the changes made. I didn't quite understand the part with the link. Were you thinking about adding the link to the book in a comment here, on this issue?

agahkarakuzu commented 4 years ago

Were you thinking about adding the link to the book in a comment here, on this issue?

Yes, in just one of the comments to the book, nothing special :) I will take a look at your changes, see you in the meeting soon!

FilipVel commented 4 years ago

@mathieuboudreau , @agahkarakuzu Guys, Should I create separate notebooks for the unpublished figures, created with matplotlib, or should I leave them out of the book completely for now?

mathieuboudreau commented 4 years ago

If they aren't the figures in the paper, I would leave them out of the Jupyter Book for now

FilipVel commented 4 years ago

So I think I've done everything that we discussed today. You can check out the results here Please update me if I need to make some other changes.

Edit: I actually added the supplemental figure, as it was somewhat present in the paper, as supporting information.

mathieuboudreau commented 4 years ago

@FilipVel It looks great! The only thing that I'd recommend (and this goes for @zelenkastiot as well) is to have text labels next to the +- code collapse buttons to explain what each block is (e.g. "Code imports", "Functions" "Script" "Plot"), and to also include the figure captions that are inside the paper for each of them, e.g.:

Capture d’écran 2020-07-07 à 15 30 05
mathieuboudreau commented 4 years ago

@FilipVel We (@zelenkastiot and @TommyBoshkovski to be exact) made the additional changes needed before sending it to the authors today - so no need to work on this on the weekend on your end!

FilipVel commented 4 years ago

Okay, great, thanks guys!

agahkarakuzu commented 4 years ago

Just trying something

AB#6

mathieuboudreau commented 4 years ago

Meeting to do list: