Notenoughmail / KubeJS-TFC

KubeJS integration for TFC
https://www.curseforge.com/minecraft/mc-mods/kubejs-tfc
MIT License
5 stars 0 forks source link

Custom crop does not drop items when it dead #12

Open Sigmenzzz opened 1 week ago

Sigmenzzz commented 1 week ago

Yeah, it just like my last issue.

Sigmenzzz commented 1 week ago

Besides, I found more problem about crop: the double crop dosen't have loot table as before; the dead wild crop still use the model of mature one but not the dead one; the default crop only drop seeds regardless of maturity

Notenoughmail commented 1 week ago

alright, I think I've sorted out all the loot table problems with custom crops

could you elaborate a little on the model problems? wild crops don't have a dead block, so I'm unsure of what you're referring to there

Sigmenzzz commented 1 week ago

the wild crop will use the model of the dead one when it's not mature but that's not the case now and makes it hard to identify the wild crop dead or not

Sigmenzzz commented 1 week ago

well, i added blockstates for it by myself, and it seems that model problem had be solved already

Notenoughmail commented 1 week ago

ah, yeah there's not a good way to automatically use the dead model for non-mature wild crops, since they aren't connected in scripts. so I'll have to add some methods to modify those and let people override them via other means, if needed, like you are now