Search doesn't detect `Enter` key / Search is not instant

NothingSpecialDev / kaiware-v1

Desktop app for installing KaiOS apps.

MIT License

21 stars 5 forks source link

Search doesn't detect `Enter` key / Search is not instant #17

Open Simon-Laux opened 2 years ago

Simon-Laux commented 2 years ago

I expect searching to accept the Enter key to search.

Alternatively it would make sense to not have the search button, but instead searching instantly. If that hurts performance there are some ways to fix the possible performance impact:

listen for onChange, not on every keypress
debounce the search call (there are libraries for debouncing on npm)
use a virtual list to only render items that are on screen: https://react-window.vercel.app/

garredow commented 2 years ago

What platform are you on? I'm on Mac and Enter triggers a search for me.

Simon-Laux commented 2 years ago

Mac currently, ah now it works, maybe I was using the wrong search terms, still the question if we should do it instant, without a button press or enter key, still remains.