Notifiarr won't start if Deluge has empty password

[ocervell]

My Deluge is only exposed locally and has no password set.

In my configuration I have:

[[deluge]]
name     = "deluge"  # Set a name to enable checks of your service.
url      = "http://192.168.1.18:8112"
password = ""

Notifiarr fails to start with:

[ERROR] 2024/05/28 10:15:55 Using Config File: /config/notifiarr.conf: getting config: setting up app: invalid application configuration provided: missing url or password: Deluge config 1
--

This used to work fine but now it fails.

[davidnewhall]

Setting a Deluge password will get you fixed right up.

[ocervell]

Yes, but I don't want a Deluge password =D My set up is local so it's overkill for me. Is there a way we can accept an empty password ?

[davidnewhall]

The Deluge author did not write it so it would work without a password. You're using a modified version. Unfortunately Notifiarr will only work with a password and there's no plans to change that.

[ocervell]

Sorry but you are wrong. I'm using the latest official Docker Deluge container and it's definitely possible to set an empty password. Test it out yourself https://hub.docker.com/r/linuxserver/deluge if you don't take my word for it.

On top of that, it used to work with notifiarr so it's most likely a recent code change (started after my latest upgrade, probably the first since ~5months) that disabled the possibility (probably something like an if check with the empty string being an empty value)...

[bakerboy448]

The Deluge author did not write it so it would work without a password. You're using a modified version. Unfortunately Notifiarr will only work with a password and there's no plans to change that.

Got confirmation from the deluge team it is possible to set to empty password.

Which is not no password

you CAN set an empty password, but given the fact that we still require you to hit ENTER on a password field i think it demonstrates that it SHOULDNT be set to empty

[ocervell]

Right ... So can we allow an empty password by modifying the line here ?

[davidnewhall]

How do I give my Deluge no password?

Okay, I set no password and it still asked for one. I feel like it used to set the password to deluge when left blank. Now it's just weird. I'll consider removing the restriction that has been in place since Deluge support was added to Notifiarr years ago.

[ocervell]

There is a slight difference between no password and an empty ("") password, we should allow the latest but not the former imo.

[davidnewhall]

What's the difference and how would you detect it?

[bakerboy448]

None vs. empty string? Is that feasible

[ocervell]

Yes. Make it a pointer the &password. If it's nil output an error, otherwise let it go through even if it's "". I've already pointed in the code where the code change needs to be made.

[davidnewhall]

hmmm