Notifiarr / website

Issue tracker for Notifiarr.com
https://notifiarr.com
7 stars 0 forks source link

Use Sonarr ReleaseTitle instead of SceneName for Non-Grabs #268

Closed notifiarr-bot closed 1 year ago

notifiarr-bot commented 1 year ago

in theory i could adjust for it and store the release from grab, compare to the download and use the grab if they are different

Origin user: nitsua Origin message: Discord Server Link Reporting user: bakerboy448 Reporting message: Discord Server Link

bakerboy448 commented 1 year ago

Grab Payload Ex https://gist.github.com/bakerboy448/04e778ef1599c40bdc4b066087ff3698 Import Payload Ex https://gist.github.com/bakerboy448/7b13cf548c9d8090fb5e6443385434aa

image

Currently the non-Grab SceneName is used as the release name which is incorrect for Season Packs

Ideally https://github.com/Sonarr/Sonarr/issues/5503 will be implemented and fix this without needing to hack around it Otherwise we'd need to conditionally use the ReleaseName from the Grab for Season Packs for Non-Grab Notifications

Awaiting triage of Sonarr 5503 to determine if we fall back and hack it or if we can have the data natively

markus101 commented 1 year ago

Not sure how 5501 applies to this GHI...

bakerboy448 commented 1 year ago

doh - too many tabs, thanks markus! :) edited thanks

======

for posterity - 5503 accepted, so will just need to handle the updated payload once implemented.

bakerboy448 commented 1 year ago

Added in sonarr https://github.com/Sonarr/Sonarr/commit/f4130d96e570c94cf8f923852cb1a70b526a53d7

austinwbest commented 1 year ago

Done on dev & nightly

austinwbest commented 1 year ago

Not sure how 5501 applies to this GHI...

Incase you didn't know, the size is broken in the release object (it seems)

[episodeFile]
    [sceneName] => East.New.York.S01E20.A......
    [size] => 1147501821

...

[release]
    [releaseTitle] => East.New.York.S01E20.A......
    [indexer] => btn
    [size] => 0
markus101 commented 1 year ago

image

I'm not able to reproduce on my end, requestb.in received the correct value (and I see it pulled out when debugging). While not Notifiarr they're using the same common function to build the payload.

bakerboy448 commented 1 year ago

some sonarr history db investigating - it looks like the size of 0 is caused by autobrr pushing releases without a size + sonarr allowing releases with a 0 size value for the push endpoint / ignoring the size factor for pushes.