NotionX / react-notion-x

Fast and accurate React renderer for Notion. TS batteries included. ⚡️
https://react-notion-x-demo.transitivebullsh.it
MIT License
4.77k stars 554 forks source link

Hot fix - new image src with file.notion.so not working #430

Closed normdoow closed 1 year ago

normdoow commented 1 year ago

Description

Notion made a change where some pages use file.notion.so as their signed urls. These srcs aren't working currently. This is a hot fix to at least get it working. Using the block image src instead just in this case.

Notion Test Page ID

d9cc0ffee90e41c4b3ab1f450c346ba7 Don't have a ton of examples to play around with because my Notion workspace isn't producing the file.notion.so srcs. 😅

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-notion-x ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 4, 2023 at 10:57PM (UTC)
react-notion-x-minimal-demo ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 4, 2023 at 10:57PM (UTC)
pbteja1998 commented 1 year ago

There is also a file at packages/notion-utils/src/get-page-image-urls – not sure where exactly that function is being used, but I think even that should be changed in a similar manner.

normdoow commented 1 year ago

There is also a file at packages/notion-utils/src/get-page-image-urls – not sure where exactly that function is being used, but I think even that should be changed in a similar manner.

Yep, I see that. I'll update and merge once I get back to my computer.

nik32co commented 1 year ago

@normdoow images are working fine now. However, the videos are still not working. is there any fix coming up for this?