Open FranciscoMoretti opened 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated (UTC) |
---|---|---|---|
react-notion-x | ❌ Failed (Inspect) | Apr 8, 2023 9:45am | |
react-notion-x-minimal-demo | ❌ Failed (Inspect) | Apr 8, 2023 9:45am |
Feedback is encouraged. I had to make a few choices here and there and I'm unsure if they are the best.
Also, it seems like deployments are failing and I can't inspect or check details. @transitive-bullshit let me know if there is anything I can do to fix them.
Description
Replaced
Lerna
andYarn
withTurbo
andPnpm
.Changes:
tsup
and lesstsc
tsup
is the recommended tool inturbo
docstsup --watch
replaces all thewatch
tasks. It automatically re-builds a package when in development tasks. Docstsup
now generates the type definitions with the configdts: true
ontsup.config.ts
Docscomposite
is not supported bytsup
, so I've changed it tofalse
https://github.com/egoist/tsup/issues/571.turbo
docs"workspace:*"
. They should get replaced by the actual version when publishing Pnpm workspaces.turbo
tasks docsturbo
linting docsturbo.json
)package.json
turbo.json
.deploy
task tovercel-deploy
in examples to avoid confusion withpnpm deploy
pnpm vercel-deploy
andpnpm run vercel-deploy
are valid from an example directorydeploy
name but that would only work withpnpm run deploy
becausepnpm deploy
is an existent pnpm command.turbo
caching.Benefits
This change has the following advantages:
dev
with a single commandTurbo Examples
The configuration was inspired by Turborepo official examples
Basic example: https://github.com/vercel/turbo/tree/main/examples/basic
CRA example: https://github.com/vercel/turbo/tree/main/examples/with-create-react-app
Kitchen sink example; https://github.com/vercel/turbo/tree/main/examples/kitchen-sink
This bugfix was needed for a correct build of
notion-x-example-full
https://github.com/NotionX/react-notion-x/pull/459Tests
[x] Installing
[x] Running a global build:
[x] Running a build from the package dir
[x] Running every dev task
[x] Running tests execute
unit
eslint
andprettier
.[x] Running dev in a single example, modifying a dependency, and verifying it rebuilds it
[x] Connecting with
nextjs-notion-starter-kit
.yarn
link and the contributing docs from that repo are still valid after this change https://github.com/transitive-bullshit/nextjs-notion-starter-kit/blob/main/contributing.md[x] Running publish executed the correct tasks
[x] Running vercel deploy
[x] The cache works as expected in all tasks