Fix block equation display issue

NotionX / react-notion-x

Fast and accurate React renderer for Notion. TS batteries included. ⚡️

https://react-notion-x-demo.transitivebullsh.it

MIT License

4.81k stars 567 forks source link

Fix block equation display issue #491

Open drjackchan opened 1 year ago

drjackchan commented 1 year ago

Description

The inline variable is hardcoded to false at the moment, making all the equations rendered to be inline equations. Fixing this issue by removing the hardcoding.

Notion Test Page ID

39a20e59ea4147f1b3e145166528ab95

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
react-notion-x	❌ Failed (Inspect)		Jun 7, 2023 0:45am
react-notion-x-minimal-demo	❌ Failed (Inspect)		Jun 7, 2023 0:45am

jacksongoode commented 1 year ago

Is this not addressed in https://github.com/NotionX/react-notion-x/pull/281?

drjackchan commented 1 year ago

I looked at change #281 , it seems to me that it is hardcoding the display mode != inline? How can that differentiate inline and block equation?