NotionX / react-notion-x

Fast and accurate React renderer for Notion. TS batteries included. ⚡️
https://react-notion-x-demo.transitivebullsh.it
MIT License
4.89k stars 571 forks source link

notion-client search api broken #498

Open seonglae opened 1 year ago

seonglae commented 1 year ago

Description

notion-client search api stopped workine with something like this error

{
  errorId: 'a35d346e-2540-4178-900d-3e1267ec727d',
  name: 'ValidationError',
  message: 'Invalid input.'
}

Notion Test Page ID

here doesn't work image

dongtong commented 1 year ago

Hi @seonglae , I have resolved this issue, and will create a pull request later. @transitive-bullshit FYI

seonglae commented 1 year ago

@dongtong Can you explain what was the problem?

seonglae commented 1 year ago

I tried some fixes but couldn't resolved it. So I just thought that Notion blocked request except official Notion API

chervonnyy commented 1 year ago

@dongtong any updates about the fix?

dongtong commented 1 year ago

@chervonnyy @seonglae Sorry, I was busy recently. @transitive-bullshit Do we have pr template in this project?

seonglae commented 1 year ago

@dongtong https://github.com/NotionX/react-notion-x/blob/master/.github/pull_request_template.md

kaichii commented 1 year ago

@dongtong Any updates?

Armster15 commented 1 year ago

Created a pull request to fix this 👉 https://github.com/NotionX/react-notion-x/pull/505

Armster15 commented 1 year ago

In the meantime while we wait for the pull request to be (hopefully) merged, you can use patch-package and the following patch file to fix the issue:

notion-client+6.15.6.patch

seonglae commented 1 year ago

I forked this repository for my project Texonom and applied @Armster15 's solution to @texonom/nclient If someone doesn't want to apply patch-package, you can use it too

stefan-ysh commented 1 year ago

In the meantime while we wait for the pull request to be (hopefully) merged, you can use patch-package and the following patch file to fix the issue:

notion-client+6.15.6.patch

I tried like this and it works now, thank you!! And I hope this PR(#505 ) will be merged soon. 🙏 @transitive-bullshit

jacksongoode commented 1 year ago

I think we just need a tag and release @transitive-bullshit

lisposter commented 1 year ago

any updates here? think we just need a release

seonglae commented 1 year ago

@lisposter @jacksongoode If you want to fix rn, you can use https://www.npmjs.com/package/@texonom/nclient for compatible package This is live example that search api is fixed