Fix broken search function

Armster15 commented 1 year ago

Description

Problem: The search function is currently broken: we get a mysterious 405 error when we prop open the dev console and inspect the search request:

An image showing https://transitivebullsh.it with a failed POST request to the search api route, with a status code of 405

It turns out that Notion slightly changed the API for search, resulting in the way the library notion-client sends the API request to Notion for searching to be broken and throw an error:

An image of Postman showing the result of the API request sent to Notion to search by notion-client

The request body in the above screenshot was generated by notion-client and I just put it in Postman to show the error that is thrown by the Notion API.

Luckily this was a quick fix! I went to Notion and performed a search and inspected how they sent the API request, and noticed a slight difference:

An image showing an API request to the Notion search API route by the Notion web app, which reveals a difference in the way the sort key is sent

For the sort key, notion-client currently sends the following:

"sort": "Relevance"

While the Notion web app sends:

"sort": {
    "field": "relevance"
}

So I changed notion-client to send the sort the same way the Notion web app sends it (which you can see in the code of this pull request) and the search function started working again!