search

NotionX / react-notion-x

Fast and accurate React renderer for Notion. TS batteries included. ⚡️
https://react-notion-x-demo.transitivebullsh.it
MIT License
4.69k stars 544 forks source link

Bug: Re-introduce the patch for syntax highlighting issues regarding C++ and F# #546

Open powersagitar opened 4 months ago

powersagitar commented 4 months ago

[!TIP] Please check out https://github.com/transitive-bullshit/nextjs-notion-starter-kit/pull/605 for a bandaid fix before this PR gets merged.

Description

@transitive-bullshit mentioned in #220 that this fix was introduced with the release of v6, but apparently it vanished from master, thus the same issue still persists.

This PR re-introduces the patch to address syntax highlighting issues caused by Notion-prism.js language identifier mismatch.

Please refer to https://github.com/transitive-bullshit/nextjs-notion-starter-kit/issues/309 and https://github.com/NotionX/react-notion-x/issues/220 for more context.

Notion Test Page ID

Before: Screenshot 2024-03-19 12 03 32

After: Screenshot 2024-03-19 11 58 14

https://powerium.notion.site/Decoding-Conditionals-A-Dive-into-if-else-switch-case-Lookup-Tables-and-Interfaces-19254846bcb64aac9c340e81518a9dac

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-notion-x ✅ Ready (Inspect) Visit Preview Mar 19, 2024 4:09pm
react-notion-x-minimal-demo ✅ Ready (Inspect) Visit Preview Mar 19, 2024 4:09pm
rimonhanna commented 2 months ago

@transitive-bullshit