Notronix / JEtsy

A Java implementation of a Java version of the Etsy API
Apache License 2.0
6 stars 9 forks source link

[ISSUE] Personalisation missing? #4

Closed gordonturner closed 1 year ago

gordonturner commented 3 years ago

First, thanks for sharing this library, looks like it has almost everything I was looking for.

Describe the bug I have a listing that has customization for primary color, secondary color and personalisation.

My understanding is that the variations should have the those values, and indeed there are nodes for 3 values, but are null.

However, looking at etsyTransaction.getListingProduct().getPropertyValues(), I have found the primary color, secondary color values, but have not found the personalisation value.

FYI, I am asking for ShopAssociations.Receipts, ShopAssociations.Transactions, ShopAssociations.Listings, not sure if that has anything to do with it?

To Reproduce Sample code here: https://gist.github.com/gordonturner/d0b0333403aaa1daaa128294e827005f https://gist.github.com/gordonturner/89ad05a8eb48c94fa75d0e66efe1a47a

It is a work in progress, so it is a little rough.

Expected behavior The variations should have the primary color, secondary color and personalisation.

Screenshots N/A

Desktop (please complete the following information):

Smartphone (please complete the following information): N/A

Additional context N/A

gordonturner commented 3 years ago

Hey @cmunden just to follow up, did some more debugging.

My request to Esty (after authenticating) was for:

etsyDataService.getShop(accessCredentials,  shopIdsOrNames,
                    ShopAssociations.Receipts,
                    ShopAssociations.Transactions,
                    ShopAssociations.Listings,
                    ShopAssociations.User)

I put a breakpoint on EtsyDataService.java line 391 to see the response back from Esty.

(https://github.com/Notronix/JEtsy/blob/master/src/main/java/com/notronix/etsy/impl/EtsyDataService.java#L391)

In the raw response, I can see the variations:

2-response-value

However when I hit the breakpoint I see the correct total number of variations in the array (three), but they are empty.

Additionally, looking closer at the object in the variations array, the type is EtsyListingInventory, which I don't think is correct.

3-object-debug-value

I am going to try and dig into how the variations are set / deserialized.

Thanks, Gord.

cmunden commented 1 year ago

Version 2 of the API has been turned off. Now moving the implementation to Version 3.