NottingHack / hms

Hackspace Management System
4 stars 7 forks source link

Fix uploadTSB so we can used native CSV format #123

Closed dpslwk closed 8 years ago

geeksareforlife commented 8 years ago

Seems to work, just running tests...

geeksareforlife commented 8 years ago

testUploadCsvValidFileNoMembers() now fails. This is passing a valid Natwest file to the function without any new members and expecting the error 'No new member payments in .csv.'.

As the new function is expecting a TSB file it is outputting 'That did not seem to be a valid bank .csv file', which causes the test to fail.

This is the test at fault, not the new code, and the test will need to be updated.

dpslwk commented 8 years ago

Given the tests are not going to be around once we get 0.5.x released and there not so quick and easy to fix i've just disabled them