search

NousResearch / Hermes-Function-Calling

MIT License
475 stars 74 forks source link

json mode schema tag not closed #19

Closed Benjoyo closed 1 week ago

Benjoyo commented 2 months ago

https://github.com/NousResearch/Hermes-Function-Calling/blob/8b8c00ca95a12d3ac68200625a08152481b49004/jsonmode.py#L94

Minor thing, but could confuse the model slightly I guess.

teknium1 commented 1 week ago

fixed https://github.com/NousResearch/Hermes-Function-Calling/commit/d3e8b88e61533c43b286b189a5521509e555dbbc