search

Nouzan / exc

An abstraction layer for exchanges
MIT License
38 stars 14 forks source link

feat: support rustls-tls #52

Closed rise0chen closed 1 year ago

Nouzan commented 1 year ago

Thank you for the pull request! However, it seems there are some issues with the feature management. Taking a look at cfg-if might be helpful.

Steps to reproduce:

cargo clippy --all-features
rise0chen commented 1 year ago

ok

Nouzan commented 1 year ago

It would be great if you could review this PR: https://github.com/rise0chen/exc/pull/1

rise0chen commented 1 year ago

Both exc-okx and exc-binance be dependent on exc.

This code can't work, and I can't solve it.

native-tls = ["exc-core/native-tls", "exc-okx?/native-tls", "exc-binance?/native-tls"]
rustls-tls = ["exc-core/rustls-tls", "exc-okx?/rustls-tls", "exc-binance?/rustls-tls"]
Nouzan commented 1 year ago

Both exc-okx and exc-binance be dependent on exc.

This code can't work, and I can't solve it.

native-tls = ["exc-core/native-tls", "exc-okx?/native-tls", "exc-binance?/native-tls"]
rustls-tls = ["exc-core/rustls-tls", "exc-okx?/rustls-tls", "exc-binance?/rustls-tls"]

It seems to be working just fine? (https://github.com/rise0chen/exc/pull/2)

rise0chen commented 1 year ago

Yes, It had worked. I thought it not work, because I found exc-binance in Cargo.lock. In fact, cargo tree and compile log no exc-binance.