search

Nova-Committee / ModernKeyBinding

Other
17 stars 1 forks source link

Does not work when Controlling is installed #5

Closed MicrocontrollersDev closed 1 year ago

MicrocontrollersDev commented 1 year ago

Details: Forge 1.8.9 11.15.1.2318 ModernKeybinding 2.1.0 Controlling 7.0.0.1 (7.0.0.1 is newer than 7.0.0.2. Not sure what's going on there but neither work anyways)

When using the two mods in conjunction, Controlling works fine but ModernKeybinding doesn't do anything. Pressing a modifier will instantly set it to the modifier and won't allow for an extra key.

MikhailTapio commented 1 year ago

We've already had a "ModernControlling" in our organization repositories. But thx to your issue, I remembered I should post that somewhere like CurseForge.

Gamemassa commented 1 year ago

We've already had a "ModernControlling" in our organization repositories. But thx to your issue, I remembered I should post that somewhere like CurseForge.

I'm noticing that Modern Keybindings does not function correctly with Controlling on Fabric 1.20.x and I'm not sure if that should be here or in its own issue thread, so I decided I'd post it here first and move it later if necessary.

MikhailTapio commented 1 year ago

We've already had a "ModernControlling" in our organization repositories. But thx to your issue, I remembered I should post that somewhere like CurseForge.

I'm noticing that Modern Keybindings does not function correctly with Controlling on Fabric 1.20.x and I'm not sure if that should be here or in its own issue thread, so I decided I'd post it here first and move it later if necessary.

Yes. Compatibility for new versions of Controlling is not implemented yet.

Gamemassa commented 1 year ago

But it is planned?

MikhailTapio commented 1 year ago

But it is planned?

Sure. Maybe a bit later

Gamemassa commented 1 year ago

Ok, thanks for confirming.

Gamemassa commented 1 year ago

@MikhailTapio Hey Mikhail, I just got a reply from jaredlll08 (the developer of Controlling) and he said he's happy to add support code (api-related stuff, in his words) in his mod, if that's easier for you.

MikhailTapio commented 1 year ago

@MikhailTapio Hey Mikhail, I just got a reply from jaredlll08 (the developer of Controlling) and he said he's happy to add support code (api-related stuff, in his words) in his mod, if that's easier for you.

Hi! Thx to Jared's help, we've made it. Use Controlling-Fabric-1.20.1-12.0.2(+) & ModernKeyBinding-Fabric-1.20.X-1.2.0(+).

MikhailTapio commented 1 year ago

I'll close this, anything else to ask plz reopen :D