dstraveller commented 3 years ago

Please peer review.

gabwhite commented 3 years ago

This is looking really nice! A few thoughts:

It might be my eagle eye for design but I think the button style is a little bit different from our default button the corners don't seem as round and there's not as much padding.
Also wondering if it might be a good opportunity to use the "button spinner" in bootstrap for after you select your file and it uploads, it's a nice way to show people that something is happening.
Should the title of what you uploaded appear after you're done attaching? that's probably something that would require a bit more development/integration right? Maybe for now we can just mock-up where the file name would go? I'm thinking above the button?

dstraveller commented 3 years ago

1: updated with default button style

3: added file name above upload button (Note: detailed js function should be done at the app level)