Nova-UTD / navigator

Navigator, our self-driving vehicle software stack
https://nova-utd.github.io/navigator
Other
32 stars 11 forks source link

Add Launch GUI (Zenith) #415

Closed akevinge closed 7 months ago

akevinge commented 7 months ago

Main Changes

Misc Changes

jruths commented 7 months ago

Sorry I missed the demo last week! I'm looking forward to seeing this!

Regarding the docker names... I guess it could be improper convention, but navigator was the name of the image and we had two services navigator_obc and navigator_carla. This allows you to docker compose build navigator and build the image (once) for both docker compose run navigator_obc and docker compose run navigator_carla. It seemed unnecessary to have two identical images named navigator_obc and navigator_carla. Does that make sense?

akevinge commented 7 months ago

Sorry I missed the demo last week! I'm looking forward to seeing this!

Regarding the docker names... I guess it could be improper convention, but navigator was the name of the image and we had two services navigator_obc and navigator_carla. This allows you to docker compose build navigator and build the image (once) for both docker compose run navigator_obc and docker compose run navigator_carla. It seemed unnecessary to have two identical images named navigator_obc and navigator_carla. Does that make sense?

In theory, it shouldn't make a difference because it navigator_obc and navigator_carla all use the same navigator image. For example: image

I had changed it because running docker compose up (note: up not run would cause the names to container names to clash). I could just be misunderstanding something though.