search

NovaEngineering-Source / StellarCore

Full range of optimization for a better 1.12.2.
https://www.curseforge.com/minecraft/mc-mods/stellarcore
GNU Lesser General Public License v3.0
34 stars 8 forks source link

Model obj warning on logs #9

Closed Sereath closed 1 month ago

Sereath commented 1 month ago

I was just wondering if this would be worth adressing:

image

    Line  8316: [20:37:45] [Client thread/WARN] [stellar_core]: [StellarCore-ParallelModelLoader] A mod trying to load model `touhou_little_maid:entity/petal.obj` without concurrent state, it may cause some performance issues.
    Line  8317: [20:37:45] [Client thread/WARN] [stellar_core]: [StellarCore-ParallelModelLoader] A mod trying to load model `touhou_little_maid:entity/knife_top.obj` without concurrent state, it may cause some performance issues.
    Line  8318: [20:37:45] [Client thread/WARN] [stellar_core]: [StellarCore-ParallelModelLoader] A mod trying to load model `touhou_little_maid:entity/knife_bottom.obj` without concurrent state, it may cause some performance issues.
    Line  8319: [20:37:45] [Client thread/WARN] [stellar_core]: [StellarCore-ParallelModelLoader] A mod trying to load model `touhou_little_maid:entity/bullet_danmaku.obj` without concurrent state, it may cause some performance issues.
    Line  8320: [20:37:45] [Client thread/WARN] [stellar_core]: [StellarCore-ParallelModelLoader] A mod trying to load model `touhou_little_maid:entity/ring.obj` without concurrent state, it may cause some performance issues.
    Line  8321: [20:37:45] [Client thread/WARN] [stellar_core]: [StellarCore-ParallelModelLoader] A mod trying to load model `touhou_little_maid:entity/gossip.obj` without concurrent state, it may cause some performance issues.
    Line  8322: [20:37:45] [Client thread/WARN] [stellar_core]: [StellarCore-ParallelModelLoader] A mod trying to load model `touhou_little_maid:entity/kunai.obj` without concurrent state, it may cause some performance issues.
    Line  8323: [20:37:45] [Client thread/WARN] [stellar_core]: [StellarCore-ParallelModelLoader] A mod trying to load model `touhou_little_maid:entity/raindrop.obj` without concurrent state, it may cause some performance issues.
    Line  8324: [20:37:45] [Client thread/WARN] [stellar_core]: [StellarCore-ParallelModelLoader] A mod trying to load model `touhou_little_maid:entity/arrowhead.obj` without concurrent state, it may cause some performance issues.
    Line  8325: [20:37:45] [Client thread/WARN] [stellar_core]: [StellarCore-ParallelModelLoader] A mod trying to load model `touhou_little_maid:entity/butterfly.obj` without concurrent state, it may cause some performance issues.
    Line 16168: [20:38:07] [Client thread/WARN] [stellar_core]: [StellarCore-ParallelModelLoader] A mod trying to load model `techguns:grenadelauncher#inventory` without concurrent state, it may cause some performance issues.
    Line 16169: [20:38:07] [Client thread/WARN] [stellar_core]: [StellarCore-ParallelModelLoader] A mod trying to load model `techguns:block/grenadelauncher.obj` without concurrent state, it may cause some performance issues.
    Line 16170: [20:38:07] [Client thread/WARN] [stellar_core]: [StellarCore-ParallelModelLoader] A mod trying to load model `techguns:grenadelauncher_1#inventory` without concurrent state, it may cause some performance issues.
    Line 16171: [20:38:07] [Client thread/WARN] [stellar_core]: [StellarCore-ParallelModelLoader] A mod trying to load model `techguns:block/grenadelauncher_1.obj` without concurrent state, it may cause some performance issues.
    Line 16172: [20:38:07] [Client thread/WARN] [stellar_core]: [StellarCore-ParallelModelLoader] A mod trying to load model `techguns:gaussrifle#inventory` without concurrent state, it may cause some performance issues.
    Line 16173: [20:38:07] [Client thread/WARN] [stellar_core]: [StellarCore-ParallelModelLoader] A mod trying to load model `techguns:block/gaussrifle.obj` without concurrent state, it may cause some performance issues.

https://gist.github.com/Sereath/ef27f499a16108c220d51e4ec0aeb3cf

Out of many content mods, only Techguns and Touhou Little Maid seem to do that.

But to be honest, I havent noticed anything wrong ingame. I just thought it was worth mentioning it. Thank you again.

KasumiNova commented 1 month ago

This is because they load models using their own model loader, which is not controlled by StellarCore. Theoretically, this will not affect usage.

Sereath commented 1 month ago

I understand, thank you for your reply.