search

NovaMachina-Mods / ExNihiloSequentia

Port of Ex Nihilo: Creatio
https://www.curseforge.com/minecraft/mc-mods/exnihilosequentia
Other
39 stars 28 forks source link

[BUG] Obsidian Transformation Broken #471

Open allanf181 opened 1 day ago

allanf181 commented 1 day ago

Is there an existing issue for this?

Current Behavior

image The stone barrel is filled with a block of air Same of #103

Expected Behavior

Stone barrels make obsidian

Steps to Reproduce

Just set up the obsian recipe automatically, with blocks that transport fluids and items in 1 tick, using for example the cyclic hopper or the io laser with maximum upgrades

Minecraft Version

1.20.X

Forge Version

47.3.7

Ex Nihilo: Sequentia Version

5.0.0.0

Additional Context

I believe that the solution in 1.16.5 applies in this case https://github.com/NovaMachina-Mods/ExNihiloSequentia/blob/1.20/src/main/java/novamachina/exnihilosequentia/world/item/crafting/SolidifyingRecipe.java#L64-L66

Log File

I'm playing on a server, so I don't have access to its logs.

allanf181 commented 19 hours ago

https://github.com/NovaMachina-Mods/ExNihiloSequentia/blob/1.20/src/main/java/novamachina/exnihilosequentia/common/registries/SolidifyingRegistry.java#L54-L57 return this.getResultItem(fluidInTank, fluidOnTop).copy() solves the issue, I tested it by writing a mixin