NovaSector / NovaSector

A Nova Sector downstream of /tg/station SS13.
GNU Affero General Public License v3.0
30 stars 268 forks source link

SolFed comms key conflicts with TG 'left-hand' comm shortcut #3977

Closed OrionTheFox closed 1 month ago

OrionTheFox commented 2 months ago

Issue Summary

TG has three comms keybinds that use specific held items to speak, rather than choosing a channel. :r for Right Hand :l (L) for Left Hand :i for Adjacent Intercom

SolFed uses the :l (L) key, conflicting with using this key to speak into left-handed radios. You still CAN, but it attempts to speak over SolFed as well. Attempting to use this bind while having the encryption key and a radio in your left hand will likely cause issues, at the least confusion. image

Round ID:

N/A

Testmerges:

N/A

Reproduction:

Hold something in your left hand Type :l (L) to use the left hand item to speak Observe that it attempts to speak over SolFed encryption

SomeRandomOwl commented 2 months ago

This has been like this for years technically, it just wasnt noticed before because we didnt update the tgui text box for the radio channel for it but that was something i added in myself to update the box for the coms like other coms do

vinylspiders commented 1 month ago

This really should be unit tested