NovaSquirrel / Mesen-X

Mesen X is a cross-platform (Windows & Linux) NES/Famicom emulator built in C++ and C#. This fork is meant to gather development efforts from different forks. Deprecated; see https://github.com/SourMesen/Mesen2/
https://www.mesen.ca
GNU General Public License v3.0
160 stars 28 forks source link

Do not disable the auto config input type option #89

Closed mkwong98 closed 2 years ago

mkwong98 commented 2 years ago

If the ROM file has a NES 2.0 header then we can get the input type even when internal game db is disabled. So we can remove the code that disable this option when the game db is disabled. https://github.com/NovaSquirrel/Mesen-X/issues/88

negativeExponent commented 2 years ago

I has minor querries about doing this. What the the default controller set on Mesen when the bit value is '0'? C0z not all NES 2.0 headers have these values set. And a value of '0' is unspecified by nes 2.0 specs

mkwong98 commented 2 years ago

It uses the current controller set.