NovaSquirrel / NovaTheSquirrel

an open source NES platformer game
GNU General Public License v3.0
202 stars 8 forks source link

Fix speech bubble positions #117

Closed NovaSquirrel closed 6 years ago

NovaSquirrel commented 6 years ago

Right now there's a bug where scene changes don't actually kick in at the right time, and I've been working around that by moving the scene changes in the script where it works properly, but now speaker changes use the positions from the old scene.

I've got the following options:

Option 2 sounds easiest and cleanest, but option 1 would be the most proper so I'll probably attempt that first.

NovaSquirrel commented 6 years ago

Fixed this in a really dumb way that involves reading from character RAM to determine if there's any text to display or not.