search

NovaSquirrel / ft2pently

Famitracker to Pently music converter
GNU General Public License v2.0
14 stars 1 forks source link

Don't rely on comments when parsing text export #36

Closed pinobatch closed 7 months ago

pinobatch commented 10 months ago

I saw this twice in ft2p.c

    // export things if needed
    if(!strcmp(buffer, "# End of export")) {

Lines beginning with # are comments. Comments are not guaranteed to appear in files exported from future versions of FamiTracker or in files exported by other tools whose output FamiTracker can import. It'd be better to perform these actions upon reaching the end of the file.

NovaSquirrel commented 7 months ago

I already refactored the code to look for the actual end of the file, rather than this comment, so I'm closing this