search

Novactive / NovaeZSEOBundle

Novactive eZ Publish and Platform SEO Bundle
MIT License
25 stars 58 forks source link

fix controller has no container set error, fix generate route #122

Closed ITernovtsii closed 4 years ago

ITernovtsii commented 4 years ago
Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no

Fixed "Novactive\Bundle\eZSEOBundle\Controller\SitemapController" has no container set, did you forget to define it as a service subscriber? Fixed generateUrl compatibility with eZ v3

SerheyDolgushev commented 4 years ago

@ITernovtsiy could you please fix the line length warning:

Run php vendor/bin/phpcs --standard=.cs/cs_ruleset.xml --extensions=php bundle/ tests/

FILE: ...EOBundle/NovaeZSEOBundle/bundle/Controller/SitemapController.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 154 | WARNING | Line exceeds 120 characters; contains 127 characters
----------------------------------------------------------------------

Time: 1.33 secs; Memory: 8MB

##[error]Process completed with exit code 1.
Plopix commented 4 years ago

thanks!

Plopix commented 4 years ago

hello thanks for this bug fix!

I have just added tests so this won't happen again!

https://github.com/Novactive/NovaeZSEOBundle/commit/c44a83962f5c67823f1dfa6f00af57ba0dab1a9d

++