search

Novactive / NovaeZSEOBundle

Novactive eZ Publish and Platform SEO Bundle
MIT License
25 stars 57 forks source link

Injected lower layer Variation Handler into MetaNameSchema #80

Closed alongosz closed 6 years ago

alongosz commented 6 years ago

This PR is a workaround for obtaining Image Variation for objects not fetched from eZ Platform Repository.

Background: due to performance issues when trying to solve missing with and height of image Variations, additional Image Variation Cache layer has been introduced via ezsystems/ezpublish-kernel#2325, which requires using here fully qualified Public API objects obtained from Repository when calling getVariation.

This workaround bypasses that new layer until we figure out cleaner solution.

Steps to reproduce the issue we have now:

  1. Install dev-master version of ezsystems/ezplatform-demo
  2. Go to home page in a web browser to see the exception.

cc @Plopix @damianz5 @SylvainGuittard

SylvainGuittard commented 6 years ago

Thanks @alongosz for the contribution!

Plopix commented 6 years ago

Awesome, thank you @alongosz I will merge and tag right now