Novage / p2p-media-loader

An open-source engine for P2P streaming of live and on demand video directly in a web browser HTML page
https://novage.com.ua/p2p-media-loader/demo.html
Apache License 2.0
1.41k stars 311 forks source link

Not working in the latest version of Chrome #277

Closed anesuc closed 7 months ago

anesuc commented 1 year ago

I have been using this library for a project of mine. Today I noticed the P2P isn't detecting new peers. Even if you open it in a new tab. It seems it still works on my other computer and I have not updated Chrome on it. Any ideas what changes in Chrome have resulted in this breaking?

anesuc commented 1 year ago

I have been doing my own debugging looking through the code and such. The issue is related to this update: https://groups.google.com/g/discuss-webrtc/c/L0qDWipd7VE?pli=1

The fix is to remove query options in the STUN URL in p2p-media-loader-core.js . I can't find the corresponding code in this repo though from a quick look.

In other words: stun:global.stun.twilio.com:3478?transport=udp becomes stun:global.stun.twilio.com:3478

renatofrota commented 1 year ago

Thank you for providing more info and the fix. It did work for me as well.

anesuc commented 1 year ago

Thank you for providing more info and the fix. It did work for me as well.

Yeah I have had my fair share of going to a thread where they say "all god figured it out" or never come back or some vague answer they jump 10 steps to get to the solution. So I make my best effort to come back haha

mvpavx commented 1 year ago

Your are my real life super hero bro! Thank you. It help me saving cost so much.