Novartis / cellxgene-gateway

Cellxgene Gateway allows you to use the Cellxgene Server provided by the Chan Zuckerberg Institute (https://github.com/chanzuckerberg/cellxgene) with multiple datasets.
Apache License 2.0
52 stars 32 forks source link

Nested s3 #46

Closed alokito closed 3 years ago

codecov-commenter commented 3 years ago

Codecov Report

Merging #46 (c29e5c0) into master (dba13cc) will increase coverage by 10.86%. The diff coverage is 95.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #46       +/-   ##
===========================================
+ Coverage   46.44%   57.30%   +10.86%     
===========================================
  Files          22       22               
  Lines         773      780        +7     
  Branches      100      100               
===========================================
+ Hits          359      447       +88     
+ Misses        403      318       -85     
- Partials       11       15        +4     
Flag Coverage Δ
unittests 57.30% <95.23%> (+10.86%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cellxgene_gateway/gateway.py 33.57% <0.00%> (ø)
cellxgene_gateway/extra_scripts.py 100.00% <100.00%> (ø)
cellxgene_gateway/filecrawl.py 82.14% <100.00%> (+30.29%) :arrow_up:
cellxgene_gateway/items/s3/s3item_source.py 72.41% <100.00%> (+72.41%) :arrow_up:
cellxgene_gateway/items/item.py 94.73% <0.00%> (+15.78%) :arrow_up:
cellxgene_gateway/items/s3/s3item.py 100.00% <0.00%> (+100.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dba13cc...c29e5c0. Read the comment docs.

alokito commented 3 years ago

This PR should fix https://github.com/Novartis/cellxgene-gateway/issues/45