search

Novartis / torchsurv

Deep survival analysis made easy
http://opensource.nibr.com/torchsurv/
MIT License
62 stars 7 forks source link

cindex equal 0 #61

Open tcoroller opened 1 week ago

tcoroller commented 1 week ago

File "/home/corolth1/torchsurv/src/torchsurv/metrics/cindex.py", line 568, in _p_value_noether raise ValueError( ValueError: The standard error of concordance index must be a positive value.

melodiemonod commented 1 week ago

Hi @tcoroller ,

I don't think the edits proposed are correct because it would lead to a division by 0 (https://github.com/Novartis/torchsurv/blob/57845ede441df4c20ea9dba3cd6c75f09376e981/src/torchsurv/metrics/cindex.py#L590).

The se should not be 0. Do you want to give me a reproducible code so I can check the error you got?

tcoroller commented 1 week ago

Sounds good, let me try to do a reproducible example

tcoroller commented 1 week ago

Unless we can do something like: (self.cindex - null_value) / (cindex_se + eps) ?

melodiemonod commented 1 week ago

I mean intuitively the c-index standard error should never be 0. I'm curious to know what can can lead to this!