search

Novartis / xgxr

R package for supporting exploratory graphics at http://opensource.nibr.com/xgx
Other
13 stars 7 forks source link

Perhaps add flagging censoring columns like they do in Monolix? #9

Closed mattfidler closed 5 years ago

mattfidler commented 5 years ago

I'm unsure if you read the monolix documentation, but I think that flagging censoring somehow may be useful for exploratory plots.

mattfidler commented 5 years ago

http://monolix.lixoft.com/data-and-models/censoreddata/

iamstein commented 5 years ago

Hey Matt, can you say more what you mean, here? Is there a specific function that you are suggesting we change? Or something in the vignettes? In the xGx site, we do have a CENS column and in some plots, highlight this BLQ data. http://opensource.nibr.com/xgx/Single_Ascending_Dose_PK.html#concentration_over_time,_faceted_by_dose,_dots_and_lines_grouped_by_individual

mattfidler commented 5 years ago

Maybe make a geom_cens that does these for you?

I was going to do something similar for nlmixr but haven't quite gotten to it.

iamstein commented 5 years ago

Hmm. I think that’s functionality I’d prefer not to implement. Because it’s so easy with ggplot already. Just set the shape equal to CENS. I tend not to like adding functions for doing things that are already easy with ggplot2. But then I guess how one defines easy is kind of arbitrary.

mattfidler commented 5 years ago

OK.