search

NovatecConsulting / BeanTest

Bean Testing for Java EE Applications
http://blog.novatec-gmbh.de/unit-testing-jee-applications-cdi/
Apache License 2.0
25 stars 12 forks source link

Issue#5 review #9

Closed bbq2100 closed 10 years ago

bbq2100 commented 10 years ago

This pull request provides altogether with small code clean-ups the requested deployment validation in #5 by @carlosbarragan. BeanTestExtension is now ensuring that a processed bean holds valid dependency injection points for its member i.e. the processed bean may hold exclusively field injection points or setter injection points for a particular bean member.

agori commented 10 years ago

As regards the @Alternative debate, I would suggest to add Arquillian to BeanTest. With arquillian you can include/exclude classes through a very simple and powerful API.

Further it would be great to transform BeanTest in an Arquillian extension (or Arquillian container?), but this is a plus.

bbq2100 commented 10 years ago

Hi Agori, I think with API you mean the ShrinkWrap API from Arquillian (http://arquillian.org/guides/shrinkwrap_introduction/), right? In #1 I also mentioned to include this feature in BeanTesting. As you said it will allow the user to create deployment descriptors individually for a specific test case.

carlosbarragan commented 10 years ago

@agori as @qabbasi mentioned. I think you are referring to ShrinkWrap. The API is quite good. However, the developer must enter every single dependency and class he wants to deploy for every test. In big projects (+15 modules) that can be a nightmare (been there), so I find that a little bit cumbersome for BeanTest. BeanTest should work with as little configuration as possible.

bbq2100 commented 10 years ago

After squashing my commits, I will close this pull request.