NovatecConsulting / novatec-service-dependency-graph-panel

A Grafana panel for visualizing a Service Dependency Graph.
Apache License 2.0
191 stars 64 forks source link

[BUG] - Namespace Delimiter field in Connection Mapping not honored #137

Open JoseAPortilloJSC opened 5 months ago

JoseAPortilloJSC commented 5 months ago

Describe the bug The "Namespace Delimiter" field is ignored, always using "." as namespace delimiter.

To Reproduce

VPNCUSTOMERNAME_PEER111.111.111.111_PEER222.222.222.222 --> 7 layers:

  • VPNCUSTOMERNAME_PEER111
  • 111
  • 111
  • 111_PEER222
  • 222
  • 222
  • 222

Expected behavior

VPNCUSTOMERNAME_PEER111.111.111.111_PEER222.222.222.222 --> 3 layers:

  • VPNCUSTOMERNAME
  • PEER111.111.111.111
  • PEER222.222.222.222

Screenshots (sorry, no screenshot of the panel due to containing sensitive information) imagen

Your Setup:

Additional context Inspecting the code, it seems that both "nameSpaceDelimiter" and "namespaceDelimiter" from the dataMapping structure are referred to. My proposal would be to use "namespaceDelimiter" in all places, in consonance with the "Namespace Delimiter" caption and because namespace is a single word, like Firefox or nonetheless. :)

Thank you! Jose