search

Novicell / novicell-frontend

Novicell default build setup, for compiling PostCSS to CSS, Babeling JS, making SVG sprites, optimizing images and more
https://frontend.novicell.cloud
29 stars 16 forks source link

Add favicons to netlify #316

Closed Dan9boi closed 5 years ago

Dan9boi commented 5 years ago

As of dist-folder being ignored, we can't get a favicon on netlify. This makes it run on netlify aswell, adding the icons to the distfolder before adding the dist folder to the build folder, that's deployed to netlify. Thanks to @hesselberg

hesselberg commented 5 years ago

💪

sebimoe commented 4 years ago

I think there is a typo, npm run is missed before build:prod so it doesn't deploy on netlify or pass checks. Also the icon file is required (assets/favicons/favicons-master.png) https://github.com/Novicell/novicell-frontend/pull/316/checks

Should it be corrected here or via a new pull request?

hesselberg commented 4 years ago

Great catch!