search

Novik / ruTorrent

Yet another web front-end for rTorrent
Other
2.03k stars 413 forks source link

web workers support #1356

Closed nelu closed 7 years ago

nelu commented 7 years ago

any plan for web workers for the ajax calls? its 2016 & browsers are moving ff

mariotacke commented 7 years ago

What's the point? How would it improve the current situation?

nelu commented 7 years ago

well, will offload the main thread (where all code is being ran right now). example: instead of "blocking" the main thread (ui thread) with ajax requests, instead the ajax call can be done from a separate thread and the request response is being sent as a event to the main UI thread to update the view. this was a simple example... anyhow to another good example on how you can have performance benefits from webworkers, is Ace Text Editor (js), which is a pretty advanced text editor on web

mobile devices will benefit mostly (the ui will be more responsive)

On Fri, Dec 16, 2016 at 8:57 AM, Mario Tacke notifications@github.com wrote:

What's the point? How would it improve the current situation?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Novik/ruTorrent/issues/1356#issuecomment-267530126, or mute the thread https://github.com/notifications/unsubscribe-auth/ADzWkxhmZiIF-fmfeW6FNDMSj2jo8UyOks5rIjZHgaJpZM4K8wsP .

mariotacke commented 7 years ago

Not sure if you understand how ajax works, but it is non-blocking. The requests are made in ajax fashion, see https://github.com/Novik/ruTorrent/blob/master/js/rtorrent.js#L1099. Also check out the docs on ajax. Webworkers would do little to speed this up but introduce lots of complexity,