Silent error when trying to move completed files

Abbotta4 commented 1 month ago

Please complete the following tasks.

[X] Web browser cache cleared
[X] Link provided to install script if applicable
[X] Not using broken rtinst install script
[X] Web browser, ruTorrent, PHP and OS version provided

Tell us about your environment

Web Browser: Google Chrome 123.0.6312.86 ruTorrent: 4.3.0 PHP: 8.3.4 OS: Arch Linux

Tell us how you installed ruTorrent

I used the existing AUR PKGBUILD found here with the 4.3.0 tarball

Describe the bug

I can not move downloaded files with the right-click menu in rtorrent

Steps to reproduce

Right click a torrent
Click "Save to..."
Choose a new directory

Expected behavior

The files should be moved to the new directory and ruTorrent should update to reflect the new location

Additional context

No Error is printed to the log module of rutorrent, but there is output to the configured error.log file:

[2024-04-03 11:18:53] <?xml version="1.0" encoding="UTF-8"?><methodCall><methodName>system.multicall</methodName><params><param><value><array><data>
<value><struct><member><name>methodName</name><value><string>d.get_name</string></value></member><member><name>params</name><value><array><data>
<value><string>87B371C275329795FE02F8BB37B0B8C44931FB7B</string></value>
</data></array></value></member></struct></value>
<value><struct><member><name>methodName</name><value><string>d.get_base_path</string></value></member><member><name>params</name><value><array><data>
<value><string>87B371C275329795FE02F8BB37B0B8C44931FB7B</string></value>
</data></array></value></member></struct></value>
<value><struct><member><name>methodName</name><value><string>d.get_base_filename</string></value></member><member><name>params</name><value><array><data>
<value><string>87B371C275329795FE02F8BB37B0B8C44931FB7B</string></value>
</data></array></value></member></struct></value>
<value><struct><member><name>methodName</name><value><string>d.is_multi_file</string></value></member><member><name>params</name><value><array><data>
<value><string>87B371C275329795FE02F8BB37B0B8C44931FB7B</string></value>
</data></array></value></member></struct></value>
<value><struct><member><name>methodName</name><value><string>d.get_complete</string></value></member><member><name>params</name><value><array><data>
<value><string>87B371C275329795FE02F8BB37B0B8C44931FB7B</string></value>
</data></array></value></member></struct></value>
</data></array></value></param></params></methodCall>
[2024-04-03 11:18:53] Status: 200 OK
Content-Type: text/xml
Content-Length: 1112

<?xml version="1.0" encoding="UTF-8"?>
<methodResponse>
<params>
<param><value><array><data>
<value><struct>
<member><name>faultCode</name>
<value><i4>-506</i4></value></member>
<member><name>faultString</name>
<value><string>Method 'd.get_name' not defined</string></value></member>
</struct></value>
<value><struct>
<member><name>faultCode</name>
<value><i4>-506</i4></value></member>
<member><name>faultString</name>
<value><string>Method 'd.get_base_path' not defined</string></value></member>
</struct></value>
<value><struct>
<member><name>faultCode</name>
<value><i4>-506</i4></value></member>
<member><name>faultString</name>
<value><string>Method 'd.get_base_filename' not defined</string></value></member>
</struct></value>
<value><array><data>
<value><i8>1</i8></value>
</data></array></value>
<value><struct>
<member><name>faultCode</name>
<value><i4>-506</i4></value></member>
<member><name>faultString</name>
<value><string>Method 'd.get_complete' not defined</string></value></member>
</struct></value>
</data></array></value></param>
</params>
</methodResponse>

I only see the commands d.get_name, d.get_base_path, d.get_base_filename, and d.get_complete in js/content.js. I am not sure why they aren't translated to d.name, d.base_path, d.base_filename, and d.complete, respectively, and I'm not sure if this is the actual root of the problem or not.

stickz commented 1 month ago

@Abbotta4 Could you try the existing release on Arch Linux, to see if you can reproduce the problem? It would be helpful to know if this is a version specific issue or if it can be reproduced anywhere on our master branch.

Abbotta4 commented 1 month ago

@Abbotta4 Could you try the existing release on Arch Linux, to see if you can reproduce the problem? It would be helpful to know if this is a version specific issue or if it can be reproduced anywhere on our master branch.

I actually was having this problem on 4.2.10 originally and tried updating to 4.3.0 to ensure I was on the latest version before submitting a bug, so I can confirm this is present on 4.2.10 as well.

Novik / ruTorrent