Use flex display on dialog windows

Novik / ruTorrent

Yet another web front-end for rTorrent

Other

2.03k stars 414 forks source link

Use flex display on dialog windows #2762

Closed jevenski closed 3 weeks ago

jevenski commented 4 weeks ago

Use flex display for dialog contents, and enable overflowing on the Y-axis if content height exceeds the max-height of windows.
Define background color and border colors using CSS variables.
Remove unused CSS rules.

stickz commented 4 weeks ago

What is the impact of this change? Do we need it in v5.1 or can it wait until v5.2? I'm getting about ready to post Beta 3 once #2760 is merged. Test it then mark v5.1 as stable to deploy to ten thousand clients.

jevenski commented 4 weeks ago

@koblack mentioned that things grow too big to fit in some of the dialog windows (https://github.com/Novik/ruTorrent/pull/2748#issuecomment-2425825286), so the scrolling needs to function properly. This can be a preparation for enlarged font size on mobile, so I think it can wait till v5.2

n1ce-0ne commented 3 weeks ago

this is exciting, i always read along, i still run an old version, im an avid fan of auto-dl irssi, since you guys are smashing this i'd call about the only thing thats stopping another ten thousand clients is the lack of it in these new versions, nothing else comes close to it, serious, if you guys wanna put the icing on the cake someone needs to look into why it wont run on this, many will be running older versions to keep auto-dl, many would update if it existed on the latest releases, just a thought!

n1ce-0ne commented 3 weeks ago

and before you say it.. just because the dev has abandoned it, doesn't mean many thousands stopped using it, it still works perfectly on the older versions & is imo the most useful feature here, many thousand others will agree im sure

n1ce-0ne commented 3 weeks ago

i'd help if i could, if its something you would consider in these new versions i'd put some time in to try help fix it

stickz commented 3 weeks ago

@n1ce-0ne Send this link to your hosting provider or use the swizzin installation script (for personal usage) to install a compatible version of autodl with the latest ruTorrent. https://github.com/swizzin/autodl-rutorrent

n1ce-0ne commented 3 weeks ago

@n1ce-0ne Send this link to your hosting provider or use the swizzin installation script (for personal usage) to install a compatible version of autodl with the latest ruTorrent. https://github.com/swizzin/autodl-rutorrent

oh wow thankyou very much, i didn't realise, keep up the great work all 😁😎🤩