Novik / ruTorrent

Yet another web front-end for rTorrent
Other
2.01k stars 408 forks source link

Label characters encoded incorrectly #913

Closed nicobubulle closed 10 years ago

nicobubulle commented 10 years ago

From kran...@gmail.com on June 25, 2014 16:58:32

When using label (d.custom1) to store, for instance, target directory -- the resulting path gets encoded incorrectly.

Example: /var/downloads/rTorrent/finished/tvshows/

becomes %2Fvar%2Fdownloads%2FrTorrent%2Ffinished%2Ftvshows%2F/

Which means the torrent's data gets moved to a /home/username/%2Fvar%2Fdownloads%2FrTorrent%2Ffinished%2Ftvshows%2F/ and rTorrent doesn't find it and is unable to seed. What steps will reproduce the problem? 1. Use the following method for moving torrents to custom dir when finished (in rtorrent.rc):

system.method.set_key = event.download.finished,move_complete,"d.set_directory=$d.get_custom1= ;execute=mv,-u,$d.get_base_path=,$d.get_custom1="

  1. Set label of torrent in ruTorrent to a valid path.
  2. Wait for torrent to finish downloading. What is the expected output? What do you see instead? What environment are you using? 1. My ruTorrent version is 3.6
  3. My rTorrent version is 1.9.2
  4. I use web-server lighttpd on Ubuntu
  5. I use browser Chrome it version is 35 on Windows 7 64-bit. Same problem with IE11 on same machine.

Original issue: http://code.google.com/p/rutorrent/issues/detail?id=917

nicobubulle commented 10 years ago

From novik65 on June 25, 2014 23:50:26

When using label (d.custom1) to store, for instance, target directory -- the resulting path gets encoded incorrectly.

This is a correct behavior.

Use the following method for moving torrents

Use autotools plugin for this.

Status: Invalid

Jolly-Pirate commented 2 years ago

I created a fix for it https://github.com/Jolly-Pirate/rtorrent-snippets/tree/master/fix-urlencoded-label