search

Novum / vkQuake

Vulkan Quake port based on QuakeSpasm
GNU General Public License v2.0
1.84k stars 223 forks source link

[Bug] Lighting/Texture regression in 1.13 #450

Closed itsbat closed 2 years ago

itsbat commented 2 years ago

On map "The Undergate" and possible other maps something related to the lighting and/or textures seem to have broke at latest version of vkquake

1.12.2 image 1.13.0 image

vsonnier commented 2 years ago

Can confirm I get the same problem on master branch :( Using either GeForce 1050Ti Mobile (471.96), or iGPU HD 630 on Windows 10x64 here.

It starts breaking at 987822fda998351d1d1cd3c9910eee8bffeaf27b

It works properly on Ironwail 0.50.

Here is a link to download the latest version of this map pack, because it is not obvious to find it these days : http://quaketastic.com/files/single_player/maps/undergate_Re-Release_2011.zip

vsonnier commented 2 years ago

Launching the game with r_gpulightmapupdate 0 added to autoexec.cfg make this (hub) map work again, so that is a workaround.

On the other hand, switching r_gpulightmapupdate on and off on the console do not seem to have any effect.

Found 2 maps that show the same problem in SM206 map pack: https://www.quaddicted.com/reviews/sm206.html These are sm206_konair and sm206_quasiotter.

temx commented 2 years ago

This happens on unlit maps, r_fullbright should also fix. Here's a broken fix: https://github.com/temx/vkQuake/commit/4269583e39e7dd9e2afce2d8d1f5c84f3f814fc3 (embedded models such as health packs will still be darker). Edit: this is wrong, there are some black surfaces with no lightstyles on lit maps.

andrei-drexler commented 2 years ago

Ironwail simply turns on fullbright automatically for unlit maps, but only in single-player mode (same as QS), so maxplayers 4 + coop 1 will result in a pitch-black map. QS also fills the lightmap with 255 for unlit maps, so in coop it will be double-bright instead. I think the best solution here is to always use fullbright mode for unlit maps. Fixed in cefa4a1200170175a68405b68a4389df8fc5170f

vsonnier commented 2 years ago

Thanks for the explanation and fix !