search

Novum / vkQuake

Vulkan Quake port based on QuakeSpasm
GNU General Public License v2.0
1.85k stars 225 forks source link

v1.31.0: failure to compile on Linux with make due to missing mimalloc include path #696

Closed bubbleguuum closed 5 months ago

bubbleguuum commented 5 months ago

Updating the openSUSE TW package to v1.31.0, I noticed this compilation failure using make (not meson):

[   10s] gcc -DNDEBUG -c -DDO_USERDIRS=1 -MMD -Wall -Wno-trigraphs -Werror -std=gnu11 -D_FILE_OFFSET_BITS=64   -O3 -flto -fweb -frename-registers -fno-asynchronous-unwind-tables -fno-ident -DUSE_CODEC_WAVE -DUSE_CODEC_FLAC -DUSE_CODEC_OPUS -DUSE_CODEC_VORBIS  -DUSE_CODEC_MIKMOD -DUSE_CODEC_UMX -I/usr/include/opus -DLINUX -I/usr/include/SDL2 -D_REENTRANT -o mem.o mem.c
[   10s] mem.c:38:9: note: ‘#pragma message: ignore stringop-overflow warnings for mimalloc v2.14+’
[   10s]    38 | #pragma message "ignore stringop-overflow warnings for mimalloc v2.14+"
[   10s]       |         ^~~~~~~
[   10s] In file included from mimalloc/static.c:17,
[   10s]                  from mem.c:45:
[   10s] mimalloc/mimalloc/internal.h:17:10: fatal error: mimalloc/types.h: No such file or directory
[   10s]    17 | #include "mimalloc/types.h"
[   10s]       |          ^~~~~~~~~~~~~~~~~~
[   10s] compilation terminated.
[   10s] make: *** [common.make:265: mem.o] Error 1
[   10s] make: Leaving directory '/home/abuild/rpmbuild/BUILD/vkQuake-1.31.0/Quake'

It can be trivially fixed with CFLAGS="-I mimalloc" make ..." thus default CFLAGS in Quake/Makefile is probably missing that statement.

Other than that, congrats for the new release and keeping vkQuake alive!

vsonnier commented 5 months ago

Thanks @bubbleguuum for catching this, the fix is in master now.